Skip to content

Conversation

s-rigaud
Copy link
Contributor

Description

I simply run TS on the project to detect typing issues.

I also found two typing inconsistencies or weird behaviors:

  • In this case, the generateStore method does not return any value but the value is assigned to the snippet of type string. I'm not sure if nothing should be return in the function or a return is missing in the called method
  • In this case a null value is passed instead of an array and no buffer type is provided so either UniformArrayNode should more parameters in the super constructor call or BufferNode constructor should be more permissive

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.42
78.33
336.42
78.33
+0 B
+0 B
WebGPU 518.01
143.92
518.01
143.92
+0 B
+0 B
WebGPU Nodes 517.48
143.81
517.48
143.81
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.41
112.17
465.41
112.17
+0 B
+0 B
WebGPU 589.89
160.02
589.89
160.02
+0 B
+0 B
WebGPU Nodes 545.26
149.56
545.26
149.56
+0 B
+0 B

@Mugen87 Mugen87 added this to the r174 milestone Feb 12, 2025
@Mugen87 Mugen87 merged commit 5dc5211 into mrdoob:dev Feb 12, 2025
12 checks passed
@s-rigaud s-rigaud deleted the fix-ts-errors branch February 17, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants