WebGPURenderer: Fix ImageBitmap flip in WebGLBackend #29866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
|
Seems like the issue doesn't happen with ImageBitmaps loaded with the GLTFLoader, this PR breaking a bunch of examples, is there any extra step being done to align BitmapImage between WebGPU and WebGL @sunag? |
|
This area is destined to flip-y frame-buffers, for external textures I recommend check here: |
|
My previous answer is a bit out of context. Could you test again? |
|
Can confirm that now both backends are aligned with flipY true and false! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is an inconsistency between WebGL and WebGPU, where ImageBitmap textures are unflipped by default.
In WebGL 2.0,
gl.UNPACK_FLIP_Y_WEBGLhas no effect on ImageBitmap uploads, so we cannot flip the texture during upload.To resolve this, I added a condition in TextureNode to flip the UV for ImageBitmap, similar to how we handle sampler textures.
This contribution is funded by Utsubo