Misc fixes #839
Merged
Misc fixes #839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 13, 2024
|
Thanks. I did a quick test on AArch64, and it seems to work as well. |
|
I would appreciate if you could test all affected (from issues) platforms. Unfortunately, this is not tested in our CI. |
|
No problem. I was in a bit of a hurry in the morning but now I've run the whole test suite on all three systems, with gmpy and python backends, and all tests passed. |
|
Sorry, to be clear: I've tested aarch64, ppc64le and sparc. Unfortunately, I don't have direct access to alpha. I'll ping someone if they could test it but it'll probably take a few days, so you may want to proceed without waiting. |
I think it's not urgent, so I'll wait. |
2d38aeb to
4206839
Compare
|
See also numpy/numpy#10288. Maybe numpy test should explicitly use np.longdouble. |
$ python -m pyperf timeit 'import random' ..................... Mean +- std dev: 396 ns +- 5 ns $ python -m pyperf timeit 'import math' ..................... Mean +- std dev: 391 ns +- 4 ns
On most systems np.float128 aren't IEEE 754 quadruples. Closes mpmath#836
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mpmath/tests/test_convert.py::test_compatibilityfails on ppc64, sparc (possibly more) #836[doctest] mpmath.calculus.optimization.steffensenfails on alpha in 1.4.0a1 #838