Skip to content

Misc fixes #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2024
Merged

Misc fixes #783

merged 2 commits into from
Apr 16, 2024

Conversation

skirpichev
Copy link
Collaborator

@skirpichev skirpichev commented Apr 10, 2024 •
edited
Loading

  • don't unpack mpf tuples directly in ctx_mp*.py
  • add signed option to to_man_exp()

@skirpichev skirpichev mentioned this pull request Apr 11, 2024
Closed
pearu
pearu approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@pearu pearu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple of comments but otherwise LGTM. Thanks, @skirpichev!

@skirpichev skirpichev requested a review from pearu April 13, 2024 05:20
pearu
pearu approved these changes Apr 13, 2024
View reviewed changes
Copy link
Contributor

@pearu pearu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple of BE nits but otherwise LGTM!

@skirpichev skirpichev marked this pull request as draft April 13, 2024 13:58
@skirpichev
Copy link
Collaborator Author

Bugfix for tan/tanh moved to #785

@skirpichev skirpichev marked this pull request as ready for review April 13, 2024 17:18
@skirpichev
Don't unpack mpf tuples directly in ctx_mp*.py
b5bd545
@skirpichev
Add signed option to to_man_exp()
610fbed 
Returning unsigned mantissa value per default is deprecated.
@skirpichev skirpichev merged commit eac9809 into mpmath:master Apr 16, 2024
@skirpichev skirpichev deleted the misc branch April 16, 2024 06:23
@skirpichev skirpichev added this to the 1.4 milestone May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@pearu pearu pearu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@skirpichev @pearu