Skip to content

Use math.isqrt in isqrt_python calculations #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 10, 2023
Merged

Use math.isqrt in isqrt_python calculations #695

merged 2 commits into from
May 10, 2023

Conversation

haru-44
Copy link
Contributor

@haru-44 haru-44 commented May 8, 2023

The isqrt_python calculation is faster using math.isqrt when x is small.

For speed comparisons, see the following PR

sympy/sympy#25111

oscarbenjamin
oscarbenjamin reviewed May 8, 2023
View reviewed changes
skirpichev
skirpichev requested changes May 9, 2023
View reviewed changes
Copy link
Collaborator

@skirpichev skirpichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, please just use math.isqrt for isqrt, isqrt_fast, etc for python versions >= 3.12, if the BACKEND is not 'gmpy' or 'sage'.

@skirpichev skirpichev merged commit 25c60dd into mpmath:master May 10, 2023
@haru-44 haru-44 mentioned this pull request May 14, 2023
Closed
7 tasks
@haru-44 haru-44 deleted the math_isqrt branch May 14, 2023 14:22
@skirpichev skirpichev added this to the 1.4 milestone May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skirpichev skirpichev skirpichev approved these changes

+1 more reviewer

@oscarbenjamin oscarbenjamin oscarbenjamin left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@haru-44 @oscarbenjamin @skirpichev