Disable MPARK_CPP14_CONSTEXPR for MSVC <= 19.15 #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest Visual Studio 2017 update (version 15.8, MSVC 19.15)
claims to support C++14 constexpr, but it does not. Compiling with
MPARK_CPP14_CONSTEXPR defined emits a litany of errors, e.g.,
5>c:\...\variant\include\mpark\variant.hpp(386): error C2131: expression did not evaluate to a constant
5>c:\...\variant\include\mpark\variant.hpp(386): note: failure was caused by a read of a variable outside its lifetime
5>c:\...\variant\include\mpark\variant.hpp(386): note: see usage of '<traits_0>'
5>c:\...\variant\include\mpark\variant.hpp(1205): note: see reference to class template instantiation 'mpark::detail::traits<Redacted, Lol>' being compiled
5>c:\...\variant\include\mpark\variant.hpp(1504): note: see reference to class template instantiation 'mpark::detail::impl<Redacted, Lol>' being compiled
Disable MPARK_CPP14_CONSTEXPR for this and previous versions of MSVC,
with the hope that this problem is addressed in the near future.
Fixes mpark#48
|
Hm, the CI failures seem spurious... is that normal? |
|
Hm.. I need to take a look at the Travis CI. It seems to have been failing with a minor version update or something. Thanks for the patch! |
|
Hi! It would be great to see an update on this PR - I'm also affected by this, and more people in #48, basically everyone that has updated to VS 15.8. |
|
By the way I think a slight improvement to this PR could be made: MSVC 19.11 up to 19.14 actually worked, it was only 19.15 where this broke. So I think |
patrikhuber
added a commit
to patrikhuber/eos
that referenced
this pull request
Oct 2, 2018
Applied the changes from mpark/variant#49. This also disables `MPARK_CPP14_CONSTEXPR` for MSVC <19.15, where it actually worked - but that's ok.
patrikhuber
added a commit
to patrikhuber/eos
that referenced
this pull request
Oct 2, 2018
Applied the changes from mpark/variant#49. This also disables `MPARK_CPP14_CONSTEXPR` for MSVC <19.15, where it actually worked - but that's ok.
|
Fixed the root cause in 657110d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest Visual Studio 2017 update (version 15.8, MSVC 19.15)
claims to support C++14 constexpr, but it does not. Compiling with
MPARK_CPP14_CONSTEXPR defined emits a litany of errors, e.g.,
Disable MPARK_CPP14_CONSTEXPR for this and previous versions of MSVC,
with the hope that this problem is addressed in the near future.
Fixes #48