Remove more obsolete classes: ObjToIntMap and UintMap #1564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These classes can be easily replaced by HashMap and sometimes HashSet without a negative performance impact.
|
@gbrail have done a test with this in HtmlUnit (core-js). Have seen no notable changed in terms of performance and all the tests are passing. From my point of view you can do this.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These classes can be easily replaced by HashMap and sometimes HashSet without a negative performance impact.
(We still have one custom hash table left in Rhino, in "EmbeddedSlotMap." Attempts to replace that particular class with HashMap make performance measurably worse.)