Fix problem with regex constructor #1552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5f103da to
2c812f4
Compare
|
Looks good -- but now that we just updated test262, could you please rebase your PR on top of the latest? (And also you'll want to "git submodule update" after doing that...) Thanks! |
The spec says that we can create a new regex passing an existing one and a different set of flags, but that does not work. This PR fixes it. We also now pass a few more test262 cases.
2c812f4 to
7b2f7cf
Compare
|
Rebased on top of master and the latest test262 suite |
|
Looks good -- thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec for ES6 says that we can create a new regex passing an existing one and a different set of flags, but that does not work. This PR fixes it (while keeping the old behavior for ES5 and below). We also now pass a few more test262 cases.
Spec link: https://tc39.es/ecma262/multipage/text-processing.html#sec-regexp-constructor
(If accepted, please squash this PR 🙂 )