Skip to content

Object.defineProperty() has to take care of ConsString (issue #1482) #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2024
Merged

Object.defineProperty() has to take care of ConsString (issue #1482) #1489

merged 1 commit into from
Jun 15, 2024

Conversation

rbri
Copy link
Collaborator

@rbri rbri commented Jun 14, 2024

No description provided.

@rbri
Copy link
Collaborator Author

rbri commented Jun 15, 2024

I think there is no problem with this, all tests are green and @gbrail suggested the same solution in #1482 - will merge this.

@rbri rbri closed this Jun 15, 2024
@rbri rbri reopened this Jun 15, 2024
@rbri rbri merged commit 644cae5 into mozilla:master Jun 15, 2024
@rbri rbri mentioned this pull request Jun 15, 2024
Closed
@rbri rbri deleted the 1482_Object_defineProperty_ConsString branch June 15, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rbri