Fix NPEs in a few places #1073
Merged
Fix NPEs in a few places #1073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes problems with null "this" parameters in: Function.prototype.call Function.prototype.apply Function.prototype.toString Object.prototype.toLocaleString This addresses all but one of the NPEs in: #988
|
Looks good to me! |
rbri
reviewed
Oct 25, 2021
| @@ -4367,7 +4369,8 @@ public static Scriptable newObjectLiteral( | |||
| Context cx, | |||
| Scriptable scope) { | |||
| Scriptable object = cx.newObject(scope); | |||
| for (int i = 0, end = propertyIds.length; i != end; ++i) { | |||
| int idCount = propertyIds == null ? 0 : propertyIds.length; | |||
| for (int i = 0, end = idCount; i != end; ++i) { | |||
There was a problem hiding this comment.
i guess we can simplify this like
end = propertyIds == null ? 0 : propertyIds.length;
for (int i = 0; i != end; ++i) {
rbri
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes problems with null "this" parameters in:
Function.prototype.call
Function.prototype.apply
Function.prototype.toString
Object.prototype.toLocaleString
This addresses all but one of the NPEs in:
Closes #988