Fixes Parser.throwStatement() #510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Parser.throwStatement() creating ThrowStatement with incorect length
|
The created ThrowStatement had its length property initialized with not a length value but the ASTNode's endposition value. |
|
Very straightforward and it doesn't break anything. However in the service of making this codebase better over time I'd still love to see a new test case. Thanks! |
This added testcase specifically fails without the fix from commit 52f97f8. Without the fix: In TokenStream.getLine(int, int) the first assertion fails since the throw statement's end position exceeds the cursor (the whole script length even). This results in a thrown AssertionError (if the assert keyword is active in the java runtime).
|
The testcase triggers a specific use of the ThrowStatement instance that, without the fix, ends up using the incorrect value. This case is how I encountered the bug, I suppose the bug mentioned in the testcase commit message should have been a seperately reported issue before initiating this pull request. |
|
Thanks for the test case! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Parser.throwStatement() creating ThrowStatement with incorect length