Skip to content

Expiry of cached commons-js script entity not updated if corresponding file resource not updated on filesystem #431

@dhogan

Description

@dhogan

Line 281 of the UrlModuleSourceProvider currently reads:
return lastModified == urlConnection.getLastModified();
It should read
return lastModified != urlConnection.getLastModified();

This error prevents the expiry date of a cached, file-based commons-js module from being updated despite the absence of filesystem modifications. Thus the ModuleSourceProviderBase will not recognize that the module entity does not require revalidation (if block on line 37 of ModuleSourceProviderBase), resulting in filesystem resolution of the commons-js entity with every script reference.

Metadata

Metadata

Assignees

No one assigned

    Labels

    CommonJSIssues related to the CommonJS implementation in Rhino

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions