Skip to content

Parent-child relationship in TaggedTemplateLiteral #1238

@kuzjka

Description

@kuzjka

Hi,

Our team is really happy to see string templates and tagged string templates support in Rhino 1.7.14.

However, I have noticed that descendants of TaggedTemplateLiteral node, which are tag (target) and string literal, don't have parent relationship with TaggedTemplateLiteral node.

It looks a little illogical to me, and among other things, breaks getAstRoot().

If parent is not set intentionally, please let me know.

I'll try to prepare a PR with tests and a fix soon.

Best regards,
Ihor.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugIssues considered a bug

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions