Skip to content

update Inter font to version 4.1 (fix bedrock #15999) #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 25, 2025

Conversation

wen-2018
Copy link
Collaborator

@wen-2018 wen-2018 commented Mar 7, 2025

Description

This PR updates the Inter font to version 4.1

  • I have documented this change in the design system.
  • I have recorded this change in CHANGELOG.md.

Issue

mozilla/bedrock#15999

Testing

Enter helpful notes for whoever code reviews this change.

@wen-2018 wen-2018 marked this pull request as draft March 7, 2025 21:00
@wen-2018 wen-2018 force-pushed the font-inter-new-version branch from 25cc364 to 609db6e Compare March 10, 2025 12:56
@maureenlholland
Copy link
Collaborator

maureenlholland commented Mar 10, 2025

Some previous exploration of variable fonts was done in 2022: #810

We might want to look at if 3 or more Inter fonts are loaded on the new refresh designed pages to get a more current performance comparison

edit: in-product pages like WNP always use Inter, so probably best to check font needs there first

@wen-2018 wen-2018 force-pushed the font-inter-new-version branch from 609db6e to fc3f571 Compare March 10, 2025 13:59
@wen-2018 wen-2018 changed the title update Inter font to version 4.1 and add new Inter variable fonts (fi… update Inter font to version 4.1 (fix bedrock #15999) Mar 10, 2025
@wen-2018 wen-2018 force-pushed the font-inter-new-version branch from fc3f571 to e514b8c Compare March 10, 2025 14:01
@wen-2018 wen-2018 marked this pull request as ready for review March 10, 2025 14:02
Copy link
Collaborator

@maureenlholland maureenlholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM r+wc ✍️

suggestion (non-blocking) update CHANGELOG to include the info about font version upgrade

Screenshot 2025-03-11 at 2 22 26 PM

seems a bit odd to me that the prod file sizes are smaller than the PR, but it's not a huge difference

PROD
prod

PR
pr

Copy link
Collaborator

@maureenlholland maureenlholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor requested change on the changelog, then good to go

@wen-2018 wen-2018 force-pushed the font-inter-new-version branch from 0158e04 to 4a2f22c Compare March 13, 2025 16:34
@stephaniehobson stephaniehobson added the Needs:Review 👋 Ready for Developer Review label Mar 13, 2025
@maureenlholland maureenlholland removed the Needs:Review 👋 Ready for Developer Review label Mar 18, 2025
Copy link
Collaborator

@maureenlholland maureenlholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc

after latest procotol release, changelog needs a minor update

@wen-2018 wen-2018 force-pushed the font-inter-new-version branch from 4a2f22c to dacaed3 Compare March 18, 2025 18:55
Copy link
Collaborator

@maureenlholland maureenlholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ 🧹

@stephaniehobson stephaniehobson merged commit 440f4b3 into mozilla:main Mar 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants