-
Notifications
You must be signed in to change notification settings - Fork 81
update Inter font to version 4.1 (fix bedrock #15999) #1026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update Inter font to version 4.1 (fix bedrock #15999) #1026
Conversation
25cc364
to
609db6e
Compare
Some previous exploration of variable fonts was done in 2022: #810 We might want to look at if 3 or more Inter fonts are loaded on the new refresh designed pages to get a more current performance comparison edit: in-product pages like WNP always use Inter, so probably best to check font needs there first |
609db6e
to
fc3f571
Compare
fc3f571
to
e514b8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM r+wc ✍️
suggestion (non-blocking) update CHANGELOG to include the info about font version upgrade
seems a bit odd to me that the prod file sizes are smaller than the PR, but it's not a huge difference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor requested change on the changelog, then good to go
0158e04
to
4a2f22c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+wc
after latest procotol release, changelog needs a minor update
4a2f22c
to
dacaed3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+ 🧹
Description
This PR updates the Inter font to version 4.1
CHANGELOG.md
.Issue
mozilla/bedrock#15999
Testing
Enter helpful notes for whoever code reviews this change.