Skip to content

Conversation

khaledosman
Copy link
Contributor

@khaledosman khaledosman commented Feb 10, 2025

What's changing

Closes #853

The current folder structure with redundant single file folders, and the components split into organisms and molecules can be confusing and difficult to navigate through as it doesn't convey which part of the app it is, or what the file/folder represents

This PR moves things around to make them easier to find and splits the frontend components by feature/page instead of the atomic design concept of organisms and molecules which doesn't really tell if the components inside are reusable and stateless or not.

How to test it

Steps to test the changes:

  1. run the project and make sure the components are being loaded properly

Additional notes for reviewers

I already...

  • Tested the changes in a working environment to ensure they work as expected
  • Added some tests for any new functionality
  • Updated the documentation (both comments in code and product documentation under /docs)
  • Checked if a (backend) DB migration step was required and included it if required

@khaledosman khaledosman marked this pull request as ready for review February 10, 2025 15:39
Copy link
Member

@aittalam aittalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Khaled!

As this was mostly a refactor, I tested the UI from your branch on the full workflow and everything works fine.
Please lmk if there's anything else I can do to check it more thoroughly, otherwise consider this an approve from me

@khaledosman khaledosman merged commit 30d60d4 into main Feb 14, 2025
17 checks passed
@khaledosman khaledosman deleted the new-workflow-api branch February 14, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor file and folder structure on the frontend
2 participants