-
Notifications
You must be signed in to change notification settings - Fork 23
refactor: fix sass deprecations and migrate to new syntax #817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaledosman
commented
Feb 6, 2025
agpituk
approved these changes
Feb 6, 2025
f67ad45
to
e2224af
Compare
b0cfd0b
to
449688f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changing
The new sass version introduce breaking changes that are currently being logged as deprecation warnings that will error out in the next major sass and vite versions. This PR aims to migrate to the latest syntax to fix these deprecation warnings.
The two main changes that affected us are:
Sass modules: https://sass-lang.com/documentation/breaking-changes/import/ & https://css-tricks.com/introducing-sass-modules/
Slash syntax: https://sass-lang.com/documentation/breaking-changes/slash-div/
How to test it
Steps to test the changes:
npm run-script build
before and after the change and compare the logged outputAdditional notes for reviewers
Some of the changes were done using the automatic migrator: https://sass-lang.com/documentation/breaking-changes/import/#automatic-migration
More info here: https://css-tricks.com/introducing-sass-modules/
I already...
/docs
)