Skip to content

Conversation

khaledosman
Copy link
Contributor

@khaledosman khaledosman commented Feb 6, 2025

What's changing

The new sass version introduce breaking changes that are currently being logged as deprecation warnings that will error out in the next major sass and vite versions. This PR aims to migrate to the latest syntax to fix these deprecation warnings.

The two main changes that affected us are:
Sass modules: https://sass-lang.com/documentation/breaking-changes/import/ & https://css-tricks.com/introducing-sass-modules/
Slash syntax: https://sass-lang.com/documentation/breaking-changes/slash-div/

How to test it

Steps to test the changes:

  1. Run npm run-script build before and after the change and compare the logged output
  2. Quickly go through the application to ensure there's no major regression bugs in the css

Additional notes for reviewers

Some of the changes were done using the automatic migrator: https://sass-lang.com/documentation/breaking-changes/import/#automatic-migration

More info here: https://css-tricks.com/introducing-sass-modules/

I already...

  • Tested the changes in a working environment to ensure they work as expected
  • Added some tests for any new functionality
  • Updated the documentation (both comments in code and product documentation under /docs)
  • Checked if a (backend) DB migration step was required and included it if required

@khaledosman khaledosman changed the title refactor: fix css deprecations and migrate to new syntax refactor: fix sass deprecations and migrate to new syntax Feb 6, 2025
Base automatically changed from strict-typescript to main February 7, 2025 10:50
@khaledosman khaledosman enabled auto-merge (squash) February 7, 2025 10:53
@khaledosman khaledosman merged commit 40e7b00 into main Feb 7, 2025
15 checks passed
@khaledosman khaledosman deleted the sass-deprecations branch February 7, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants