Use custom sql init (sqlite) #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7d68c4d to
17830b8
Compare
agpituk
requested changes
Sep 30, 2024
Also, can we add local.db to .gitignore? |
Hm. I don't know what's the policy here. The idea is that the user will place the db file wherever they see fit, so the mounted local.db could end up outside the tree, or even be called something else. So I wouldn't add such a particular file name to .gitignore :-/ |
5a93ff2 to
1f98f0b
Compare
agpituk
approved these changes
Oct 4, 2024
chainlink
approved these changes
Oct 7, 2024
f9edb8e to
552e89a
Compare
Use a relative SQLite db file as default in compose. Leave postgres env vars.
552e89a to
bf00c5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changing
The whole DB URL is passed through the environment. This allows a custom DB to be used without any changes.
How to test it
Start the lumigator image using the provided URL, and removing the postgresql service from the docker compose. SQLite should be used instead locally in the lumigator image.
Related Jira Ticket
LUMI-86
Additional notes for reviewers
I already...