Skip to content

Why highlight types and constants? #20

@isker

Description

@isker

Hi. Thanks for this nice theme.

After trying it out for a while, I don't understand why so much is being highlighted in yellow.

Here's an example with a random illustrative file from the deno repository:
Screen Shot 2022-06-02 at 16 52 49

false, true, null, number literals, TextEncoder, Promise, etc are all highlighted here, due to usages of stimmung-themes-light-highlight-color here:

;; syntax
`(font-lock-builtin-face ((t (:background ,stimmung-themes-light-highlight-color :italic t))))
`(font-lock-comment-delimiter-face ((t (:background ,str :italic t))))
`(font-lock-comment-face ((t (:background ,str :italic t))))
`(font-lock-doc-face ((t (:background ,str :italic t))))
`(font-lock-constant-face ((t (:background ,stimmung-themes-light-highlight-color :italic t))))
`(font-lock-function-name-face ((t (:foreground ,fg1 :bold t))))
`(font-lock-keyword-face ((t (:foreground ,fg1))))
`(font-lock-type-face ((t (:background ,stimmung-themes-light-highlight-color))))
`(font-lock-variable-name-face ((t (:foreground ,fg1 :bold t))))
`(font-lock-negation-char-face ((t (:foreground ,fg1))))
`(font-lock-preprocessor-face ((t (:foreground ,fg1))))
`(font-lock-preprocessor-char-face ((t (:foreground ,fg1))))
`(font-lock-regexp-grouping-backslash ((t (:foreground ,fg1 :bold t))))
`(font-lock-regexp-grouping-construct ((t (:foreground ,fg1 :bold t))))
`(font-lock-string-face ((t (:foreground ,fg1 :background ,str))))
`(font-lock-warning-face ((t (:foreground ,fg1 :underline (:style wave :color ,warning)))))
`(font-lock-doc-markup-face ((t (:background ,stimmung-themes-light-highlight-color))))

It seems a bit much, and it's not clear why constants and typenames deserve to be highlighted. I could of course override this, but I'd also like to hear what you think.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions