Skip to content
This repository was archived by the owner on May 22, 2024. It is now read-only.
This repository was archived by the owner on May 22, 2024. It is now read-only.

React Warning when remove() OB in componentWillUnmount #82

@gilbox

Description

@gilbox

Is this a bug?

  // get a warning about forceUpdate of an unmounted component
  componentWillUnmount() {
    ob.remove();
  }
  // no warning
  componentWillUnmount() {
    ob.atomically().remove().commit({notify: false});
  }

we could fix this by checking c.isMounted() in the render function but is this a case where the correct thing to do is the second approach?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions