Skip to content

Only include JCTools in executionShadedJCTools #1514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

gabro
Copy link
Contributor

@gabro gabro commented Nov 9, 2021

Currently JCTools accidentally brings in scala-collection-compat, this change makes sure that only JCTools is included and nothing else)

Here's the content of the currently published jar

~/Downloads/monix-internal-jctools_2.13-3.3.0
❯ tree -L 4
.
├── META-INF
│   └── MANIFEST.MF
├── monix
│   └── execution
│       └── internal
│           └── jctools
├── scala
│   ├── collection
│   │   └── compat
│   │       ├── immutable
│   │       ├── package$.class
│   │       └── package.class
│   └── util
│       └── control
│           └── compat
└── scala-collection-compat.properties

All the scala/collection/compat stuff shouldn't probably be there and it can cause conflicts when running assembly in an app which brings in a different version of scala-collection-compat (e.g. scala-collection-compat.properties will conflict).

This bug was originally reported on the Scala Discord (see https://discordapp.com/channels/632150470000902164/635669047588945930/907577696270295070)

A similar, and maybe more general fix could be to "reset" the libraryDependencies to Nil in assemblyShadeSettings (although that's currently only used by the jctools module)

Currently JCTools accidentally brings in scala-collection-compat, this change makes sure that only JCTools is included and nothing else)
@alexandru alexandru merged commit 3c3e987 into monix:series/3.x Nov 10, 2021
@gabro gabro deleted the patch-2 branch November 10, 2021 17:39
alexandru pushed a commit that referenced this pull request May 9, 2022
Currently JCTools accidentally brings in scala-collection-compat, this change makes sure that only JCTools is included and nothing else)
alexandru pushed a commit that referenced this pull request May 9, 2022
Currently JCTools accidentally brings in scala-collection-compat, this change makes sure that only JCTools is included and nothing else)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants