Skip to content

Refactor core errors #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Mar 4, 2020
Merged

Refactor core errors #193

merged 23 commits into from
Mar 4, 2020

Conversation

Alex-D
Copy link
Member

@Alex-D Alex-D commented Feb 25, 2020 •
edited
Loading

jsdidierlaurent
jsdidierlaurent reviewed Feb 26, 2020
View reviewed changes
@Alex-D Alex-D force-pushed the refactor-core-errors branch from 3a548e6 to ef42f57 Compare February 27, 2020 01:49
@codecov
Copy link

codecov bot commented Feb 27, 2020 •
edited
Loading

Codecov Report

Merging #193 into develop will decrease coverage by 0.46%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #193      +/-   ##
===========================================
- Coverage    83.31%   82.85%   -0.47%     
===========================================
  Files           84       97      +13     
  Lines         2583     2945     +362     
  Branches        87      102      +15     
===========================================
+ Hits          2152     2440     +288     
- Misses         431      505      +74
Flag Coverage Δ
#core 99.01% <100.00%> (+0.11%) ⬆️
#ui 32.06% <31.05%> (+2.95%) ⬆️
Impacted Files Coverage Δ
ui/src/helpers/getTileDoc.ts 14.28% <0.00%> (ø)
ui/src/helpers/extractFieldValue.ts 0.00% <0.00%> (ø)
ui/src/helpers/splitList.ts 0.00% <0.00%> (ø)
ui/src/helpers/jsonSyntaxColor.ts 0.00% <0.00%> (ø)
monitorable/config/models/errors.go 100.00% <0.00%> (ø)
ui/src/helpers/formatConfigExtract.ts 7.14% <0.00%> (ø)
monitorable/config/models/configversion.go 100.00% <0.00%> (ø)
ui/src/components/Errors.vue 31.42% <0.00%> (ø)
ui/src/helpers/parsedExpectedValue.ts 16.66% <0.00%> (ø)
ui/src/enums/configErrorId.ts 100.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ffbc07...8f12aa9. Read the comment docs.

@Alex-D Alex-D force-pushed the refactor-core-errors branch from ef42f57 to 16e5de5 Compare February 27, 2020 01:50
Alex-D
Alex-D commented Feb 27, 2020
View reviewed changes
Alex-D
Alex-D commented Feb 27, 2020
View reviewed changes
@Alex-D Alex-D linked an issue Feb 27, 2020 that may be closed by this pull request
Better errors formatting in config API response #191
Closed
@jsdidierlaurent jsdidierlaurent force-pushed the refactor-core-errors branch 2 times, most recently from b404ad6 to 86343c8 Compare February 29, 2020 15:55
@jsdidierlaurent jsdidierlaurent marked this pull request as ready for review February 29, 2020 16:01
@Alex-D Alex-D force-pushed the refactor-core-errors branch from fd5b3ad to 2e92a38 Compare March 3, 2020 01:23
This was linked to issues Mar 3, 2020
Improve config path/URL presence check and display in UI #201
Closed
Add a check on UI to show an error when Core API is unreachable/timeout #200
Closed
Make config errors human-readable in UI #199
Closed
Improve config versioning #186
Closed
@Alex-D Alex-D merged commit 9342725 into develop Mar 4, 2020
@Alex-D Alex-D deleted the refactor-core-errors branch March 4, 2020 02:19
@Alex-D Alex-D linked an issue Mar 4, 2020 that may be closed by this pull request
Add missing theme documentation (?theme=dark) #203
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsdidierlaurent jsdidierlaurent jsdidierlaurent left review comments

Assignees
No one assigned
Labels
core high priority refactor semver:major ui
Projects
None yet
Milestone
No milestone
2 participants
@Alex-D @jsdidierlaurent