Skip to content

Add zoom parameter and mobile support based on it #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 25, 2020
Merged

Add zoom parameter and mobile support based on it #180

merged 5 commits into from
Feb 25, 2020

Conversation

Alex-D
Copy link
Member

@Alex-D Alex-D commented Feb 21, 2020 •
edited
Loading

  • Core
  • UI
  • Documentation
  • Core tests

Fix #114

@codecov
Copy link

codecov bot commented Feb 21, 2020 •
edited
Loading

Codecov Report

Merging #180 into develop will decrease coverage by 0.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #180      +/-   ##
==========================================
- Coverage    83.32%   83.3%   -0.02%     
==========================================
  Files           84      84              
  Lines         2573    2582       +9     
  Branches        86      87       +1     
==========================================
+ Hits          2144    2151       +7     
- Misses         429     431       +2
Flag Coverage Δ
#core 98.9% <100%> (ø) ⬆️
#ui 29.11% <50%> (+0.14%) ⬆️
Impacted Files Coverage Δ
monitorable/config/usecase/usecase.go 100% <ø> (ø) ⬆️
ui/src/components/Tile.vue 15% <ø> (ø) ⬆️
monitorable/config/models/config.go 100% <ø> (ø) ⬆️
ui/src/store.ts 21.64% <0%> (-0.23%) ⬇️
ui/src/App.vue 67.3% <100%> (+1.3%) ⬆️
monitorable/config/usecase/verify.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e59a9d...f257368. Read the comment docs.

@Alex-D Alex-D force-pushed the feat-zoom branch 3 times, most recently from 27e1e1d to a522b24 Compare February 24, 2020 14:35
@Alex-D Alex-D merged commit 6dd4585 into develop Feb 25, 2020
@Alex-D Alex-D deleted the feat-zoom branch February 25, 2020 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsdidierlaurent jsdidierlaurent jsdidierlaurent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add scale factor (zoom in / out)
2 participants
@Alex-D @jsdidierlaurent