Remove Host:Port in hydrated configuration #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
=========================================
- Coverage 97.2% 97.2% -0.01%
=========================================
Files 47 47
Lines 1394 1393 -1
=========================================
- Hits 1355 1354 -1
Misses 39 39
Continue to review full report at Codecov.
|
jsdidierlaurent
commented
Oct 2, 2019
798d677 to
c2bde2e
Compare
BREAKING CHANGE: In hydrated config, we replace tile url (host:port/path?params) by url without host:port (/path?params)
Now, front URL has some new available query parameters: - `apiBaseUrl`: the root API URL - `configUrl`: an URL to the config - `configPath`: a relative path to the config on the server BREAKING CHANGE: old URL was http://localhost:8000/?config=http://localhost:8080/api/v1/config?path=.%2Ftest%2Ffaker-config.json new one is http://localhost:8000/?apiBaseUrl=http://localhost:8080&configPath=.%2Ftest%2Ffaker-config.json
c2bde2e to
ba2fe42
Compare
|
fix: #99 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I remove host:port injection in hydrate step.
Next is only in front. Poke @Alex-D