Feat/add dynamic tiles #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this, the code is 10 times more simpler, but the client errors will
be a bit less explicit :
- unknown key will be ignored and not prompt
- parsing will be more strict ("params": "test" will be handle
unmarshall error)
- add struct for create dynamic tile (jenkins, gitlab ...) - add dynamic tile check in config - add dynamic tile hydration - add tests
Errors / Warnings array has been added in config returned to front
Golang's standard regex library doesn't have negative look ahead because "a regular expression that doesn't complete in O(n) time isn't a regular expression"
Alex-D
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dynamic tiles structures and jenkins multibranch gestion
fix #71
fix #76