Skip to content

Conversation

mongolyy
Copy link
Owner

@mongolyy mongolyy commented Jan 7, 2025

fix #79

This tool uses reviewdog/action-suggester.
The action-suggester is not supported for -fail-level and we must continue to use -fail-on-error.

#79 has occurred because the default value setting for -fail-on-error was removed in #77.
In order to prioritize compatibility, the default value setting for -fail-on-error is temporarily reverted.

I think the action-suggester will be improved, and when it is improved, I will respond to #81.

@mongolyy mongolyy self-assigned this Jan 7, 2025
@mongolyy mongolyy force-pushed the feature/79_fix-bug branch from 97f0b1e to ad2799d Compare January 7, 2025 16:04
@mongolyy mongolyy changed the title Refactors argument handling for reviewdog execution Restore the default value for fail_on_error Jan 7, 2025
@mongolyy mongolyy marked this pull request as ready for review January 7, 2025 16:21
@mongolyy
Copy link
Owner Author

mongolyy commented Jan 7, 2025

I confirmed that the problem was resolved.
mongolyy/reviewdog-action-biome-sandbox#1

Copy link

github-actions bot commented Jan 7, 2025

🏷️ [bumpr] Next version:v1.8.1 Changes:v1.8.0...mongolyy:feature/79_fix-bug

@mongolyy mongolyy merged commit e4145b9 into main Jan 7, 2025
14 checks passed
@mongolyy mongolyy deleted the feature/79_fix-bug branch January 7, 2025 16:23
Copy link

github-actions bot commented Jan 7, 2025

🚀 [bumpr] Bumped! New version:v1.8.1 Changes:v1.8.0...v1.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'invalid boolean value "" for -fail-on-error: parse error' - action fails in v1.8.0
1 participant