Skip to content

Add String cache for BsonArray indexes. #1664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 2, 2025
Merged

Add String cache for BsonArray indexes. #1664

merged 6 commits into from
Apr 2, 2025

Conversation

vbabanin
Copy link
Member

@vbabanin vbabanin commented Mar 29, 2025 •
edited
Loading

@vbabanin vbabanin self-assigned this Mar 31, 2025
@vbabanin vbabanin marked this pull request as ready for review April 1, 2025 04:25
@vbabanin vbabanin requested a review from rozza April 1, 2025 15:08
rozza
rozza approved these changes Apr 1, 2025
View reviewed changes
Copy link
Member

@rozza rozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

One optional suggestion.

@vbabanin @rozza
Update bson/src/main/org/bson/BsonBinaryWriter.java
fd61c35 
Co-authored-by: Ross Lawley <ross.lawley@gmail.com>
@vbabanin vbabanin merged commit a86b3df into mongodb:main Apr 2, 2025
2 of 3 checks passed
@ShaneHarvey
Copy link
Member

FYI we cache the first 1000 keys in Python: https://github.com/mongodb/mongo-python-driver/blob/4.11.3/bson/__init__.py#L646

@vbabanin vbabanin mentioned this pull request Apr 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rozza rozza rozza approved these changes

Assignees

@vbabanin vbabanin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vbabanin @ShaneHarvey @rozza