Skip to content

TxUtils: use regex to check for valid domain #4243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2024
Merged

TxUtils: use regex to check for valid domain #4243

merged 1 commit into from
Jan 18, 2024

Conversation

selsta
Copy link
Collaborator

@selsta selsta commented Nov 13, 2023

hinto-janai
hinto-janai approved these changes Nov 27, 2023
View reviewed changes
Copy link

@hinto-janai hinto-janai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linked issue is fixed, normal domains still work.

Some interesting domains can pass through but they correctly error on resolve.

image

@luigi1111 luigi1111 merged commit f284677 into monero-project:master Jan 18, 2024
@selsta selsta deleted the regex-openalias branch March 9, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@plowsof plowsof plowsof approved these changes

@hinto-janai hinto-janai hinto-janai approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@selsta @plowsof @hinto-janai @luigi1111