Skip to content

Conversation

georgeef
Copy link
Contributor

@georgeef georgeef commented Dec 4, 2024

In Navigator tree, align Dashboard to other top-level items.

Implementation

  • Add a non-visible root item.
  • Dashboard is the first child of the root item (it was the root before).
  • Adjust spacing of open/close symbols (a little more compact layout, the symbols still show clearly the hierarchy).

Test

  • Tested on macOS.

This change is Reviewable

@whalley whalley added this to the v1.9.0 milestone Dec 6, 2024
@whalley whalley merged commit 859b61b into moneymanagerex:master Dec 6, 2024
4 checks passed
@n-stein
Copy link
Contributor

n-stein commented Dec 6, 2024

Add a non-visible root item.
Dashboard is the first child of the root item (it was the root before).

This causes a crash whenever the nav tree is reset (#6998). I've put fixes under PR #6999.

Adjust spacing of open/close symbols (a little more compact layout, the symbols still show clearly the hierarchy).

I think this is making it impossible to collapse first-level nodes on Windows.

This was also caused by wxTR_HIDE_ROOT. Needed to explicitly enable lines at root level. Also now fixed under #6999.

@georgeef
Copy link
Contributor Author

georgeef commented Dec 6, 2024

Thank you @n-stein

On macOS I don't see any of these issues. I compiled wxWidgets-3.2.6 with --enable-debug and MMEX with -DCMAKE_BUILD_TYPE=Debug. I don't get any alert at startup, the top-level items can expand and collapse, and I could delete a transaction without crash.

@whalley Do you see the issues above?

@georgeef
Copy link
Contributor Author

georgeef commented Dec 6, 2024

This is how it looks on macOS:

809C955C-DE72-45A8-A12A-22AC851D532C

@georgeef
Copy link
Contributor Author

georgeef commented Dec 6, 2024

I tested #6999 on macOS, it looks good (I don't see any difference).

@ovari
Copy link
Contributor

ovari commented Dec 7, 2024

Should the screenshots be updated before next release?

Should the screenshots be updated after:

  1. the Dashboard image is updated?
  2. Add executions of scheduled transactions in transaction panels #6860 has be implemented?

Can you please advise where the MMEX data file is which is used for creating the screenshots?

Thank you

@ovari
Copy link
Contributor

ovari commented Dec 7, 2024

Right-clicking on "Dashboard" brings up the "Theme Manager". Is that the desired behavior? Thank you

@georgeef
Copy link
Contributor Author

georgeef commented Dec 7, 2024

Right-click on "Dashboard" did not change with this PR. I don't know the history of this behavior, but if there are no other settings for "Dashboard", it is ok to bring something else which is useful.

It could open [Options -> Dashboard] instead, which is more relevant.

@whalley whalley added the fixed label Dec 13, 2024
@georgeef georgeef deleted the fix_navtree branch December 21, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants