Skip to content

Conversation

georgeef
Copy link
Contributor

@georgeef georgeef commented Sep 14, 2024

This PR depends on #6873.

New feature

When a single execution of a scheduled transaction is selected in a transactions panel (either for a single account or "All Transactions"), the "Duplicate" button is enabled. If this button is pressed, a transaction dialog is opened with data copied from the scheduled transaction. In contrast to "Enter" (which is enabled only when the first execution of a scheduled transaction is selected), the original scheduled transaction is not modified.

Implementation

  • In Fused_Transaction, define typedef id_t, getEmptyData(), getFusedData(), split().

  • In the mmTransDialog, rename m_trx_data to m_fused_data and change its type to Fused_Transaction::Data; define enum MODE; replace bool m_new_trx, bool m_duplicate with MODE m_mode.

  • In the mmTransDialog constructor, change the third argument from int transaction_id to Fused_Transaction::id_t fused_id.

Additional changes

  • In Model_Checking, rename splittransaction() -> split().

This change is Reviewable

@whalley whalley removed the on hold waiting for something label Dec 1, 2024
@whalley whalley added the on hold waiting for something label Dec 1, 2024
@georgeef
Copy link
Contributor Author

georgeef commented Dec 1, 2024

Replaced by #6981.

@georgeef georgeef closed this Dec 1, 2024
@whalley whalley removed this from the v1.9.0 milestone Dec 13, 2024
@georgeef georgeef deleted the new_mmcheckingpanel-3 branch December 21, 2024 14:59
@georgeef georgeef changed the title new(#6860): duplicate scheduled transaction to transaction new(#6860), part 3: duplicate scheduled transaction to transaction Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold waiting for something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants