Skip to content

Database encryption change to AES256 #6871

@grumpy235

Description

@grumpy235

MMEX version:

  • 1.7.0
  • [] 1.8.0
  • [X ] 1.8.1
  • 1.8.2
  • Other (please specify)

Note: bug reporters are expected to have verified the bug still exists
either in the last stable version of MMEX or on updated development code
(master branch).

Operating System:

  • Windows
  • Mac OSX
  • Linux

Description of the bug

Just downloaded 1.8.1-RC.1 from Appveyor and confused by the following..
Screenshot 2024-09-12 150802
This shows aes128cbc, MMEX has been changed to use AES256cbc by "#6538 Upgrade database encryption to AES256".

Looking at the code in util.cpp, this displays the default...

wxSQLite3Cipher::GetCipherName(wxSQLite3Cipher::GetGlobalCipherDefault())

which has not changed.

The AES256 implementation has been made by specifying AES256 in the MMEX source where ever it is required.

Personally I would vote to remove aes128cbc from the Database line on the "About panel" as to my mind it only serves to confuse and is rather meaningless now.
Alternatively perhaps hardcode AES256 ?

Add screenshot or other files if needed.

Reproduction

Is the bug reproducible?

  • Always
  • Randomly
  • Happened only once

Reproduction steps:

Expected result:

Actual result:

Additional information

If you have a backtrace for a crash or a warning, paste it here.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions