Refactored provider signing to use trusted signing #5837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gary Bright <gary@mondoo.com>
f42e701 to
b15fb8b
Compare
|
I ran the workflow and made sure it worked all the way through, when I re-ran it using the other certificate I only validated a few and canceled the workflow, hence why there is a lot of errors. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the windows provider file signing process from DigiCert to Azure Trusted Signer.
Key Changes
Removed redundant tasks: Some tasks became unnecessary after switching to Azure and were removed to simplify the workflow.
Azure-specific tasks: Added new tasks to handle authentication required for jsign to work with Azure. Authentication to micrsoft is done using OIDC
Note: jsign was upgraded on the runner to version 7.1, which supports trusted signing.
Workflow Improvements
New inputs were added to the workflow_dispatch to aid with troubleshooting: