⚠️ Warn if an MQL resource does not have id set. #5825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tas50
reviewed
Aug 4, 2025
tas50
reviewed
Aug 4, 2025
tas50
reviewed
Aug 4, 2025
Signed-off-by: Preslav <preslav@mondoo.com>
Signed-off-by: Preslav <preslav@mondoo.com>
Signed-off-by: Preslav <preslav@mondoo.com>
ca906d2 to
4f78c7e
Compare
Signed-off-by: Preslav <preslav@mondoo.com>
3779abe to
590a774
Compare
jaym
approved these changes
Aug 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only warn for now since this will break existing resources that do not have an id set. We should first see how many such resources we have and only make this mandatory after
I need to regen all lr code but id like to first review the actual LR compiler change