Skip to content

✨ Use AWS built-in paginators. #5810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 28, 2025
Merged

✨ Use AWS built-in paginators. #5810

merged 3 commits into from
Jul 28, 2025

Conversation

VasilSirakov
Copy link
Contributor

@VasilSirakov VasilSirakov commented Jul 28, 2025 •
edited
Loading

In this PR:

  • Replaces NextToken and NextMarker code with the built-in AWS Go SDK paginators.
  • Replaces for i := range loops with for _, item := range.
  • Partially simplifies old for loops with variable reassignment. Example:
for _, region := range regions {
    regionVal := region // removed
    ...
}

There are too many remaining occurrences so I decided to finish it in a separate PR.

@VasilSirakov
✨ Use AWS built-in paginators.
ccaabfc 
Signed-off-by: Vasil Sirakov <sirakov97@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 28, 2025 •
edited
Loading

Test Results

4 362 tests  ±0   4 358 ✅ ±0   2m 11s ⏱️ -8s
  408 suites ±0       4 💤 ±0 
   30 files   ±0       0 ❌ ±0 

Results for commit d09d761. ± Comparison against base commit 11d999d.

♻️ This comment has been updated with latest results.

@VasilSirakov
Move comment.
b311580 
Signed-off-by: Vasil Sirakov <sirakov97@gmail.com>
@VasilSirakov
Fix comments.
d09d761 
Signed-off-by: Vasil Sirakov <sirakov97@gmail.com>
@VasilSirakov VasilSirakov merged commit 32689f1 into main Jul 28, 2025
17 checks passed
@VasilSirakov VasilSirakov deleted the vasil/use-aws-paginators branch July 28, 2025 10:52
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@preslavgerchev preslavgerchev preslavgerchev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VasilSirakov @preslavgerchev