Skip to content

🧹 Fix some compiler warnings and conditionals in AWS provider. #5808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 25, 2025
Merged

🧹 Fix some compiler warnings and conditionals in AWS provider. #5808

merged 3 commits into from
Jul 25, 2025

Conversation

VasilSirakov
Copy link
Contributor

@VasilSirakov VasilSirakov commented Jul 25, 2025 •
edited
Loading

In this PR:

  • Fixes some conditionals where the wrong variable was checked.
  • Removes redundant err checks.
  • Modifies loops to value-only instead of index-only where you need to index rawResources.Data[i].(mqlType).

@VasilSirakov
🧹 Fix some compiler warnings and conditionals in AWS provider.
8170b72 
Signed-off-by: Vasil Sirakov <sirakov97@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 25, 2025 •
edited
Loading

Test Results

4 362 tests  ±0   4 358 ✅ ±0   2m 11s ⏱️ -11s
  408 suites ±0       4 💤 ±0 
   30 files   ±0       0 ❌ ±0 

Results for commit 3bd0c15. ± Comparison against base commit 44986c6.

♻️ This comment has been updated with latest results.

@VasilSirakov
Use value-only range for loops.
11fe628 
Signed-off-by: Vasil Sirakov <sirakov97@gmail.com>
VasilSirakov
VasilSirakov commented Jul 25, 2025
View reviewed changes
@VasilSirakov
Remove redundant check.
3bd0c15 
Signed-off-by: Vasil Sirakov <sirakov97@gmail.com>
@VasilSirakov VasilSirakov force-pushed the vasil/minor-aws-improvements branch from b38a340 to 3bd0c15 Compare July 25, 2025 11:24
@VasilSirakov VasilSirakov merged commit 11d999d into main Jul 25, 2025
17 checks passed
@VasilSirakov VasilSirakov deleted the vasil/minor-aws-improvements branch July 25, 2025 12:39
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@preslavgerchev preslavgerchev preslavgerchev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VasilSirakov @preslavgerchev