Make properties work properly #5795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arlimus
approved these changes
Jul 23, 2025
There was a problem hiding this comment.
Amazing update!! woooooot 🎉
nitpick 1
go run ./apps/cnquery scan -f packprops.mql.yaml --json --props userHome='return "foo"' | jq .
followed by the example output, where we can see that the default prop from the policy is being applied. Is the command not matching the output perhaps? (it look slike the command would override it with foo, just like in the example below)
nitpick 2
any reason to include variant-check in the last example?
|
I've fixed the comment for nitpick 1. I copied over the wrong command, it should not have any props in the CLI command.
|
- Props are now namespaced to either a pack or query
- Props on packs need to reference props through `for`
- We will automatically make the `for` references if a pack does
not define any props but includes queries with props
Examples:
```yaml
packs:
- uid: example1
name: Example policy 1
version: "1.0.0"
authors:
- name: Mondoo
email: hello@mondoo.com
groups:
- title: group1
filters: return true
queries:
- uid: variant-1
- uid: variant-2
- uid: variant-3
- uid: variant-4
props:
- uid: userHome
for:
- uid: home
- uid: homeDir
mql: return "ex"
queries:
- uid: variant-check
title: Variant check
variants:
- uid: variant-1
- uid: variant-2
- uid: variant-3
- uid: variant-1
mql: props.home + " on 1"
props:
- uid: home
mql: return "p1"
- uid: variant-2
mql: props.home + " on 2"
props:
- uid: home
mql: return "p2"
- uid: variant-3
mql: props.homeDir + " on 3"
props:
- uid: homeDir
mql: return "p3"
- uid: variant-4
mql: props.user + " is the user"
props:
- uid: user
mql: return "ada"
```
```
go run ./apps/cnquery scan -f packprops.mql.yaml --json --props userHome='return "foo"' | jq .
```
```json
{
"assets": {
"//explorer.api.mondoo.com/assets/309tMfGA9ieUOgzgBdSMBNSEl6t": {
"mrn": "//explorer.api.mondoo.com/assets/309tMfGA9ieUOgzgBdSMBNSEl6t",
"name": "planetexpress"
}
},
"data": {
"//explorer.api.mondoo.com/assets/309tMfGA9ieUOgzgBdSMBNSEl6t": {
"values": {
"FCEF4O8XoOs=": {
"content": {
"user.+": "ada is the user"
}
},
"JvBACGPwF6o=": {
"content": {}
},
"NsipGp24tRk=": {
"content": {
"home.+": "ex on 1"
}
},
"OU6YpdHiWPQ=": {
"content": {
"home.+": "ex on 2"
}
},
"V/uj0v1oehI=": {
"content": {}
},
"yNnJGUyTSts=": {
"content": {
"homeDir.+": "ex on 3"
}
}
}
}
}
}
```
```
go run ./apps/cnquery scan -f ~/Downloads/packprops.mql.yaml --json --props userHome="return 'foo'" | jq .
```
```json
{
"assets": {
"//explorer.api.mondoo.com/assets/309tWggTTzYD0E1FDi20NmN4Bh2": {
"mrn": "//explorer.api.mondoo.com/assets/309tWggTTzYD0E1FDi20NmN4Bh2",
"name": "planetexpress"
}
},
"data": {
"//explorer.api.mondoo.com/assets/309tWggTTzYD0E1FDi20NmN4Bh2": {
"values": {
"FCEF4O8XoOs=": {
"content": {
"user.+": "ada is the user"
}
},
"JvBACGPwF6o=": {
"content": {}
},
"NsipGp24tRk=": {
"content": {
"home.+": "foo on 1"
}
},
"OAKBq9so/78=": {
"content": {}
},
"OU6YpdHiWPQ=": {
"content": {
"home.+": "foo on 2"
}
},
"yNnJGUyTSts=": {
"content": {
"homeDir.+": "foo on 3"
}
}
}
}
}
}
```
```
packs:
- uid: example1
name: Example policy 1
version: "1.0.0"
authors:
- name: Mondoo
email: hello@mondoo.com
groups:
- title: group1
filters: return true
queries:
- uid: variant-1
- uid: variant-2
- uid: variant-3
- uid: variant-4
queries:
- uid: variant-check
title: Variant check
variants:
- uid: variant-1
- uid: variant-2
- uid: variant-3
- uid: variant-1
mql: props.home + " on 1"
props:
- uid: home
mql: return "p1"
- uid: variant-2
mql: props.home + " on 2"
props:
- uid: home
mql: return "p2"
- uid: variant-3
mql: props.homeDir + " on 3"
props:
- uid: homeDir
mql: return "p3"
- uid: variant-4
mql: props.user + " is the user"
props:
- uid: user
mql: return "ada"
```
```
go run ./apps/cnquery scan -f ~/Downloads/packprops.mql.yaml --json --props home="return 'foo'" | jq .
```
```
{
"assets": {
"//explorer.api.mondoo.com/assets/309tniQ7vAYnVTMznDD7A94kqEV": {
"mrn": "//explorer.api.mondoo.com/assets/309tniQ7vAYnVTMznDD7A94kqEV",
"name": "planetexpress"
}
},
"data": {
"//explorer.api.mondoo.com/assets/309tniQ7vAYnVTMznDD7A94kqEV": {
"values": {
"FCEF4O8XoOs=": {
"content": {
"user.+": "ada is the user"
}
},
"JvBACGPwF6o=": {
"content": {}
},
"NsipGp24tRk=": {
"content": {
"home.+": "foo on 1"
}
},
"OAKBq9so/78=": {
"content": {}
},
"OU6YpdHiWPQ=": {
"content": {
"home.+": "foo on 2"
}
},
"SHIUM1ACvIk=": {
"content": {}
},
"yNnJGUyTSts=": {
"content": {
"homeDir.+": "p3 on 3"
}
}
}
}
}
}
```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
forforreferences if a pack doesnot define any props but includes queries with props
Examples:
{ "assets": { "//explorer.api.mondoo.com/assets/309tMfGA9ieUOgzgBdSMBNSEl6t": { "mrn": "//explorer.api.mondoo.com/assets/309tMfGA9ieUOgzgBdSMBNSEl6t", "name": "planetexpress" } }, "data": { "//explorer.api.mondoo.com/assets/309tMfGA9ieUOgzgBdSMBNSEl6t": { "values": { "FCEF4O8XoOs=": { "content": { "user.+": "ada is the user" } }, "JvBACGPwF6o=": { "content": {} }, "NsipGp24tRk=": { "content": { "home.+": "ex on 1" } }, "OU6YpdHiWPQ=": { "content": { "home.+": "ex on 2" } }, "V/uj0v1oehI=": { "content": {} }, "yNnJGUyTSts=": { "content": { "homeDir.+": "ex on 3" } } } } } }{ "assets": { "//explorer.api.mondoo.com/assets/309tWggTTzYD0E1FDi20NmN4Bh2": { "mrn": "//explorer.api.mondoo.com/assets/309tWggTTzYD0E1FDi20NmN4Bh2", "name": "planetexpress" } }, "data": { "//explorer.api.mondoo.com/assets/309tWggTTzYD0E1FDi20NmN4Bh2": { "values": { "FCEF4O8XoOs=": { "content": { "user.+": "ada is the user" } }, "JvBACGPwF6o=": { "content": {} }, "NsipGp24tRk=": { "content": { "home.+": "foo on 1" } }, "OAKBq9so/78=": { "content": {} }, "OU6YpdHiWPQ=": { "content": { "home.+": "foo on 2" } }, "yNnJGUyTSts=": { "content": { "homeDir.+": "foo on 3" } } } } } }