Skip to content

✨ Fail linting if query has no datapoints/entrypoints. #1755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2025
Merged

✨ Fail linting if query has no datapoints/entrypoints. #1755

merged 1 commit into from
Jul 31, 2025

Conversation

preslavgerchev
Copy link
Contributor

@preslavgerchev preslavgerchev commented Jul 31, 2025 •
edited
Loading

Following up on mondoohq/cnquery#5788

A query that would panic during execution because it has no datapoints/entrypoints is now reported when doing policy linting:

→ lint policy bundle file=test.yaml
  RULE ID                       LEVEL    FILE       LINE  MESSAGE                                                                                                                                                                                                                                  
  bundle-compile-error          error    test.yaml  1     Could not compile policy bundle: failed to validate query '//local.cnspec.io/run/local-execution/queries/check-1': failed to compile query '(asset.eol.date - time.now() > 90*time.day) && (asset.eol.date - time.now() < 180*time.day)  
                                                          ': failed to compile: received an empty code structure. this is a bug with the query compilation                                                                                                                                         
                                                                                                                                                                                                                                                                                                   
  policy-required-tags-missing  warning  test.yaml  2     policy 'test-uid' does not contain the required tag `mondoo.com/category`                                                                                                                                                                
  policy-required-tags-missing  warning  test.yaml  2     policy 'test-uid' does not contain the required tag `mondoo.com/platform`                                                                                                                                                                
FTL invalid policy bundle

To make this a lint-only feature for now, we use the provided feature flag for this to not break anything else

To test, here's a sample one:

policies:
  - uid: test-uid
    name: Test
    version: 1.0
    groups:
      - title: Check EOL
        filters: |
          asset.platform != ''
        checks:
          - uid: check-1
queries:
  - uid: check-1
    title: Check EOL
    impact: 100
    mql: |
      (asset.eol.date - time.now() > 90*time.day) && (asset.eol.date - time.now() < 180*time.day)

@preslavgerchev
✨ Fail linting if query has no datapoints/entrypoints.
d717741 
Signed-off-by: Preslav <preslav@mondoo.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 31, 2025 •
edited
Loading

Test Results

  1 files   28 suites   1m 18s ⏱️
518 tests 517 ✅ 1 💤 0 ❌
519 runs  518 ✅ 1 💤 0 ❌

Results for commit d717741.

♻️ This comment has been updated with latest results.

@preslavgerchev preslavgerchev merged commit cd2eb23 into main Jul 31, 2025
22 of 23 checks passed
@preslavgerchev preslavgerchev deleted the preslav/lint-ctx branch July 31, 2025 16:00
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jaym jaym jaym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@preslavgerchev @jaym