[bugfix] add standalone and format to "cs" locale #5749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@petrbela could you take a look? |
petrbela
suggested changes
Oct 8, 2020
src/locale/cs.js
Outdated
| @@ -90,7 +95,7 @@ export default moment.defineLocale('cs', { | |||
| monthsShortRegex: monthsRegex, | |||
| // NOTE: 'červen' is substring of 'červenec'; therefore 'červenec' must precede 'červen' in the regex to be fully matched. | |||
| // Otherwise parser matches '1. červenec' as '1. červen' + 'ec'. | |||
| monthsStrictRegex: /^(leden|ledna|února|únor|březen|března|duben|dubna|květen|května|červenec|července|červen|června|srpen|srpna|září|říjen|října|listopadu|listopad|prosinec|prosince)/i, | |||
| monthsStrictRegex: /^(leden|ledna|února|únor|březen|března|duben|dubna|květen|května|červenec|července|červen|června|srpena|srpna|srpen|září|říjena|říjen|října|listopada|listopadu|listopad|prosinec|prosince)/i, | |||
There was a problem hiding this comment.
I think the original line covers all inflections, so this change is not needed
There was a problem hiding this comment.
Can you also revert this line pls?
src/test/locale/cs.js
Outdated
| @@ -120,7 +120,7 @@ test('format ordinal', function (assert) { | |||
| }); | |||
|
|
|||
| test('format month', function (assert) { | |||
| var expected = 'leden led_únor úno_březen bře_duben dub_květen kvě_červen čvn_červenec čvc_srpen srp_září zář_říjen říj_listopad lis_prosinec pro'.split( | |||
| var expected = 'ledna led_února úno_března bře_dubna dub_května kvě_června čvn_července čvc_srpena srp_září zář_říjena říj_listopada lis_prosince pro'.split( | |||
There was a problem hiding this comment.
Suggested change
| var expected = 'ledna led_února úno_března bře_dubna dub_května kvě_června čvn_července čvc_srpena srp_září zář_říjena říj_listopada lis_prosince pro'.split( | |
| var expected = 'ledna led_února úno_března bře_dubna dub_května kvě_června čvn_července čvc_srpna srp_září zář_října říj_listopadu lis_prosince pro'.split( |
src/test/locale/cs.js
Outdated
| @@ -133,6 +133,30 @@ test('format month', function (assert) { | |||
| } | |||
| }); | |||
|
|
|||
| test('format month case', function (assert) { | |||
| var months = { | |||
| nominative: 'ledna_února_března_dubna_května_června_července_srpena_září_říjena_listopada_prosince'.split( | |||
There was a problem hiding this comment.
Suggested change
| nominative: 'ledna_února_března_dubna_května_června_července_srpena_září_říjena_listopada_prosince'.split( | |
| nominative: 'ledna_února_března_dubna_května_června_července_srpna_září_října_listopadu_prosince'.split( |
Co-authored-by: Petr Bela <bela.petr@gmail.com>
|
@petrbela Thanks for providing correct inflections, i've updated them in the latest commit. All tests passed successfully everything looks good, ready to be merged . |
|
@petrbela can you take a look at it? |
petrbela
suggested changes
Oct 21, 2020
src/locale/cs.js
Outdated
| @@ -90,7 +95,7 @@ export default moment.defineLocale('cs', { | |||
| monthsShortRegex: monthsRegex, | |||
| // NOTE: 'červen' is substring of 'červenec'; therefore 'červenec' must precede 'červen' in the regex to be fully matched. | |||
| // Otherwise parser matches '1. červenec' as '1. červen' + 'ec'. | |||
| monthsStrictRegex: /^(leden|ledna|února|únor|březen|března|duben|dubna|květen|května|červenec|července|červen|června|srpen|srpna|září|říjen|října|listopadu|listopad|prosinec|prosince)/i, | |||
| monthsStrictRegex: /^(leden|ledna|února|únor|březen|března|duben|dubna|květen|května|červenec|července|červen|června|srpena|srpna|srpen|září|říjena|říjen|října|listopada|listopadu|listopad|prosinec|prosince)/i, | |||
There was a problem hiding this comment.
Can you also revert this line pls?
monthsStrictRegex reverted to its original values
|
@petrbela as you said I've reverted "monthsStrictRegex" to its original value. |
petrbela
approved these changes
Oct 22, 2020
|
@marwahaha the inflections here are wrong, i have created a PR to fix this @petrbela could you please take a look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5074
I've updated the "cs" locale by implementing standalone and formats, I was confused why these changes were needed because cs locale code was able to handle inflections like
leden - ledna.únor - únorabřezen-březnaetc without any problems. Then I realized adding format and standalone to 'cs' locale makes the code consistent with other locales like 'hi' and 'ru' .After making changes to the "cs" locale it's test needed to be updated because of moment expecting standalone values, I also added 'format month case test' for accusations and nominations.
Now, for the most part, cs locale code is consistent with other locales, but if you feel something needs to be changed I can do that.