feat(generate-object,stream-object): add strict option #205
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @kwaa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the generateObject and streamObject functions by adding a configurable strict option. This provides users with more granular control over the application of strict JSON schema transformations, allowing them to opt out of this behavior if desired, while preserving the current strictness as the default.
Highlights
- New Feature: Strict Option: Introduced a new
strictoption to bothgenerateObjectandstreamObjectfunctions. This option allows users to explicitly control whether a strict JSON schema transformation is applied during the object generation and streaming processes. - Default Behavior Maintained: The
strictoption defaults totrue. This ensures that the existing behavior of applying strict JSON schema validation remains the default, providing backward compatibility while offering flexibility. - Internal Schema Handling: Refactored the internal logic within
generateObjectandstreamObjectto conditionally apply thestrictJsonSchematransformation based on the newstrictoption. The option is also propagated to the underlying text generation/streaming functions.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request introduces a 'strict' option to the generateObject and streamObject functions, allowing users to control whether strict JSON schema validation is applied. The changes involve adding a 'strict' option to the configuration interfaces, modifying the schema processing logic to conditionally apply strict validation, and updating the function calls to pass the 'strict' option.
No description provided.