feat(tool): add strict option #204
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @kwaa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've implemented a new feature that adds a strict option to the tool definition utilities. This enhancement provides greater control over how tool parameters are validated, allowing for an opt-out of strict JSON schema validation when desired. This change introduces more flexibility for tool consumers while maintaining the existing strict validation as the default behavior.
Highlights
- New
strictoption for tool definitions: I've introduced an optionalstrictboolean property to bothRawToolOptionsandToolOptionsinterfaces. This allows consumers to specify whether the tool's parameters should be strictly validated against their defined JSON schema. - Conditional application of strict schema validation: The
rawToolandtoolfunctions have been updated to accept and utilize this newstrictoption. Whenstrictis explicitly set tofalse, thestrictJsonSchematransformation is bypassed, allowing for more lenient parameter validation. - Default behavior remains strict: By default, if the
strictoption is not provided, the tools will continue to behave as before, applying strict JSON schema validation to their parameters. This ensures backward compatibility while providing new flexibility.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a strict option to the tool and rawTool utilities, allowing consumers to control whether strictJsonSchema is applied to the tool parameters. The implementation is sound and defaults to the previous strict behavior. My feedback focuses on a minor code consistency improvement to enhance readability and maintainability.
No description provided.