fix(xsschema): fix strict json schema in nested object #203
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @kwaa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a bug in the strictJsonSchema utility where the additionalProperties: false rule was not being applied recursively to nested object definitions. The change ensures that all object types within a generated strict JSON schema correctly disallow undeclared properties, improving the accuracy and robustness of schema validation. New tests have been added to verify this behavior.
Highlights
- JSON Schema Strictness: I've updated the
strictJsonSchemafunction to recursively applyadditionalProperties: falseto nested object schemas. Previously, this strictness was only applied to the top-level schema, allowing extra properties in nested objects. This change ensures that the strictness is enforced throughout the entire schema structure. - Improved Test Coverage: New test cases have been added for
strictJsonSchema, specifically including a test for nested objects. This new test validates that theadditionalProperties: falserule is correctly propagated to all sub-objects within a schema, confirming the fix.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request fixes an issue where strictJsonSchema was not being applied recursively to nested objects. The change correctly traverses the properties of a schema to set additionalProperties: false on all nested objects, and adds tests to verify this behavior. My review includes feedback to make the schema detection logic more robust and a note on the current limitations of the recursive implementation for future consideration.
closed #202