fix(provider-cloud): set apiKey in Azure AI Foundry endpoint #195
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @Inokinoki, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request resolves a critical issue within the Azure cloud provider's authentication mechanism. The previous implementation failed to properly set the Authorization header when the API key was supplied as a simple string, leading to potential authentication failures. My changes ensure that the API key is always correctly used to construct the bearer token and is included in the outgoing requests, regardless of its type, thereby enhancing the stability of Azure API calls.
Highlights
- API Key Handling Fix: I've addressed a bug in the Azure provider where the
Authorizationheader was not being set correctly whenoptions.apiKeywas provided as a direct string. Previously, it only handled cases whereoptions.apiKeywas an asynchronous function. - Improved Robustness: The change ensures that the API key is consistently processed and included in the request headers, whether it's a string or an async function, making the Azure integration more reliable.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request fixes a bug where string-based API keys for the Azure provider were not being correctly used to set the Authorization header. However, it introduces a regression: if no API key is provided, an invalid header (Authorization: Bearer undefined) is sent, which would cause all requests to fail. I've provided a suggestion to fix this by ensuring the header is only set when an API key is present.
|
NVM |
|
Re-open this because |
950124c to
63e09a3
Compare
|
LGTM, but pls fix lint first |
Thanks for correcting the title! I decide to remove the change recommended by Gemini, because the type of apiKey is already forced to be non-nullable. |
During an attempt to upgrade according to Azure API, I also found that
options.apiKeyisnot setnot put as "Bearer" token in the current implementation, if it's a string instead of async callable.Try to fix this