Skip to content

Conversation

nekomeowww
Copy link
Member

Description

Linked Issues

Additional context

Copy link

netlify bot commented Jul 18, 2025

Deploy Preview for airi-docs ready!

Name Link
🔨 Latest commit fdff0c6
🔍 Latest deploy log https://app.netlify.com/projects/airi-docs/deploys/687aa25a9e2641000814690d
😎 Deploy Preview https://deploy-preview-296--airi-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Jul 18, 2025

Deploy Preview for airi-vtuber ready!

Name Link
🔨 Latest commit fdff0c6
🔍 Latest deploy log https://app.netlify.com/projects/airi-vtuber/deploys/687aa25afbde71000824a5e2
😎 Deploy Preview https://deploy-preview-296--airi-vtuber.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nekomeowww nekomeowww requested a review from LemonNekoGH July 18, 2025 19:37
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @nekomeowww, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the application's interaction with Large Language Models by implementing a dynamic tool compatibility discovery system. This ensures that the application only attempts to use tools with models that explicitly support them, preventing potential errors and improving the overall stability and user experience. The changes span core LLM logic, UI integration, and testing infrastructure.

Highlights

  • Dynamic Tool Compatibility Discovery: Introduced a robust mechanism within the llm store to dynamically discover whether a selected Large Language Model (LLM) supports tool usage. This is achieved by attempting API calls with and without tools enabled and analyzing specific error messages from providers like Ollama and OpenRouter. The results are cached to optimize performance.
  • Conditional Tool Passing: The core stream function in the llm store has been updated to conditionally include tools in the request payload only if the active model has been discovered to support them. This prevents errors and improves robustness when interacting with models that do not have tool-calling capabilities.
  • UI Integration for Tool Discovery: The InteractiveArea.vue components across stage-tamagotchi, stage-web, and stage-web/mobile applications now actively trigger the tool compatibility discovery whenever the user switches the active AI provider or model. This ensures that the system is always aware of the current model's capabilities.
  • Testing and Dependency Updates: Added Vitest as a testing framework and introduced a new test file (llm.test.ts) to validate the tool compatibility discovery logic. Various @xsai/shared dependencies have been updated to newer versions, likely to support new error handling and other features.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a crucial feature for discovering tool compatibility with various providers, which significantly enhances the robustness of the application. The implementation is well-thought-out, especially with the addition of tests and caching for the discovery results. My review focuses on a few areas to improve maintainability and resilience. I've suggested refactoring some duplicated logic in the Vue components into a reusable composable. I also pointed out that the error handling in the core discovery logic is a bit brittle due to its reliance on string matching, and I've proposed a more robust approach. Finally, I've made a suggestion to simplify or at least clarify a complex custom promise utility function. Overall, these are great changes that move the project forward. Addressing these points will make the new functionality even more solid.

@nekomeowww nekomeowww merged commit 9aa5fe9 into main Jul 19, 2025
14 checks passed
@nekomeowww nekomeowww deleted the dev/fix-tool-used-without-discovery branch July 19, 2025 05:42
Copy link
Member

@LemonNekoGH LemonNekoGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

COOL

@nekomeowww nekomeowww mentioned this pull request Jul 16, 2025
Disqort pushed a commit to Disqort/airi that referenced this pull request Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants