feat(stage-ui): Live2D vs VRM page switch botton and VRM model uploading functionality #290
Conversation
✅ Deploy Preview for airi-vtuber ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for airi-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Summary of Changes
Hello @Lilia-Chen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces significant new features to the stage-ui, primarily enabling the management and display of VRM (3D) models alongside existing Live2D (2D) models. It provides a user-friendly interface for switching between these model types and allows users to upload their own VRM models from files or URLs, enhancing the avatar customization capabilities.
Highlights
- UI for Model Switching: I've added dedicated buttons on both the Live2D and VRM model setting pages, allowing users to seamlessly switch between configuring their 2D (Live2D) and 3D (VRM) avatars. This enhances the user experience by providing clear navigation between different model types.
- VRM Model Upload Functionality: I've implemented the core functionality for uploading VRM models. Users can now load VRM models either by selecting a file from their local system or by providing a URL to a VRM model, significantly expanding the customization options for 3D avatars.
- Internationalization Support: New internationalization keys have been added for both English and Simplified Chinese locales to support the newly introduced UI elements, ensuring a consistent and localized experience for users worldwide.
- VRM State Management: A new Pinia store (
vrm.ts) has been introduced to manage the state related to VRM models, including the selected model file, URL, loading source, and loading status. This centralizes VRM-specific data and logic.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces new functionality for switching between Live2D and VRM models and uploading VRM models. The changes are a great step forward. My review focuses on fixing a critical memory leak related to file handling, correcting some logical errors in the UI, and improving maintainability by addressing duplicated code and configuration values. Addressing these points will make the new feature more robust and reliable. I have included a code suggestion that you can apply directly.
packages/stage-ui/src/components/Scenarios/Settings/ModelSettings/VRMScene.vue
Outdated
Show resolved
Hide resolved
packages/stage-ui/src/components/Scenarios/Settings/ModelSettings/VRM.vue
Outdated
Show resolved
Hide resolved
packages/stage-ui/src/components/Scenarios/Settings/ModelSettings/VRMScene.vue
Outdated
Show resolved
Hide resolved
packages/stage-ui/src/components/Scenarios/Settings/ModelSettings/VRMScene.vue
Outdated
Show resolved
Hide resolved
packages/stage-ui/src/components/Scenarios/Settings/ModelSettings/VRM.vue
Outdated
Show resolved
Hide resolved
|
Apply Gemini suggestions. Thanks. |
84036ce to
16efb7b
Compare
packages/stage-ui/src/components/Scenarios/Settings/ModelSettings/VRM.vue
Outdated
Show resolved
Hide resolved
packages/stage-ui/src/components/Scenarios/Settings/ModelSettings/VRMScene.vue
Outdated
Show resolved
Hide resolved
packages/stage-ui/src/components/Scenarios/Settings/ModelSettings/VRMScene.vue
Outdated
Show resolved
Hide resolved
…ngs/VRM.vue Co-authored-by: Neko <neko@ayaka.moe>
packages/stage-ui/src/components/Scenarios/Settings/ModelSettings/VRMScene.vue
Outdated
Show resolved
Hide resolved
…ngs/VRMScene.vue Co-authored-by: Neko <neko@ayaka.moe>
Co-authored-by: Neko <neko@ayaka.moe>
Co-authored-by: Neko <neko@ayaka.moe>
Co-authored-by: Neko <neko@ayaka.moe>
…ngs/VRMScene.vue Co-authored-by: Neko <neko@ayaka.moe>
…ngs/VRMScene.vue Co-authored-by: Neko <neko@ayaka.moe>
Co-authored-by: Neko <neko@ayaka.moe>
|
Thank you very much for your help and guidance! |
…ing functionality (moeru-ai#290) --------- Co-authored-by: Neko <neko@ayaka.moe>
Description
I've added some code to:
Thanks for your review, help and any advice.