-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix(workspace): missing fonts #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ Deploy Preview for airi-docs failed. Why did it fail? →
|
✅ Deploy Preview for airi-vtuber ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @nekomeowww, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request resolves an issue with missing fonts across the workspace by standardizing the handling and serving of local font assets. It updates the UnoCSS build configuration to correctly locate and process fonts from a new dedicated static directory, and adjusts the .gitignore
to align with this revised structure, ensuring fonts are properly managed and available.
Highlights
- Font Asset Configuration: Configured the
createLocalFontProcessor
inuno.config.ts
to explicitly usepublic/assets/static-fonts
as the source directory for font assets and/assets/static-fonts
as their serving base URL. This standardizes the location and serving path for local fonts. - Git Ignore Rules Refinement: Broadened the
.gitignore
rules for font directories. Replaced specific application-level paths (e.g.,packages/stage-ui/public/assets/fonts/
) with more generic, workspace-wide patterns (**/public/assets/fonts/
and**/public/assets/static-fonts/
) to ensure all relevant font locations are consistently ignored.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request centralizes fonts into a single directory and updates the .gitignore
file and UnoCSS configuration accordingly.
**/public/assets/fonts/ | ||
**/public/assets/static-fonts/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of the **
glob can be overly broad and might lead to unintentionally ignoring font directories in other parts of the repository. To make the ignore rules more specific, scope them to the directories where fonts are expected.
{apps,packages}/*/public/assets/fonts/
{apps,packages}/*/public/assets/static-fonts/
Description
Linked Issues
Additional context