-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(stage-web): launch setup #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stage-web): launch setup #259
Conversation
Fix: First time setup dialog with proper parameter naming and type as…
- Fix import paths from 'scenes' to 'Scenes' to match actual directory name - Update Vite alias configuration to use proper case-sensitive paths - Ensures TypeScript compiler compatibility across different platforms Fixes type errors related to file name casing differences between Windows file system and TypeScript module resolution. Related to issue moeru-ai#254
…ponents - Replace custom dialog implementation with radix-vue Dialog components - Replace custom button components with AIRI UI Button component - Replace custom provider selection buttons with RadioCardDetail component - Replace custom input components with AIRI UI Input component - Ensure full compliance with AIRI design system guidelines - Improve accessibility with proper labels and required field indicators Resolves moeru-ai#254
…b.com/Me1td0wn76/airi into feat/issue-254-first-launch-api-setup
✅ Deploy Preview for airi-vtuber ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for airi-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @Me1td0wn76, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a crucial first-time user experience enhancement by implementing a guided setup dialog for AI provider API keys and base URLs. This dialog, appearing on initial launch or when essential API configurations are missing, streamlines the onboarding process by allowing users to quickly configure their preferred AI services. The changes are integrated across both the desktop and web applications, supported by a new Pinia store for state management and comprehensive internationalization.
Highlights
- New First-Time Setup Dialog: A new dialog component (
FirstTimeSetupDialog.vue
) has been introduced to guide users through initial API key and base URL configuration for AI providers. It supports selecting popular providers, inputting credentials, and includes real-time validation. - Cross-Application Integration: The setup dialog is integrated into both the
stage-tamagotchi
(desktop) andstage-web
(web) applications, ensuring a consistent first-launch experience across platforms. - Dedicated State Management: A new Pinia store (
firstTimeSetup.ts
) manages the state of the first-time setup, determining when the dialog should be shown (based on completion status or existing essential provider configurations) and handling skip/completion actions. - UI Component Reorganization: Several import paths for UI components (e.g.,
WidgetStage
,Live2DCanvas
) have been updated to reflect a capitalization change in their directory structure (components/scenes
tocomponents/Scenes
). This is a refactoring of the component import paths. - Internationalization Support: New localization strings have been added for the first-time setup dialog in English and Simplified Chinese, covering all text elements within the new UI.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request introduces a first-time setup dialog for API configuration. Reviewers noted potential issues with i18n keys, debouncing, state management, and the reliability of the setup dialog's display logic.
packages/stage-ui/src/components/FirstTimeSetup/FirstTimeSetupDialog.vue
Outdated
Show resolved
Hide resolved
packages/stage-ui/src/components/FirstTimeSetup/FirstTimeSetupDialog.vue
Outdated
Show resolved
Hide resolved
packages/stage-ui/src/components/FirstTimeSetup/FirstTimeSetupDialog.vue
Outdated
Show resolved
Hide resolved
packages/stage-ui/src/components/FirstTimeSetup/FirstTimeSetupDialog.vue
Outdated
Show resolved
Hide resolved
packages/stage-ui/src/components/FirstTimeSetup/FirstTimeSetupDialog.vue
Outdated
Show resolved
Hide resolved
packages/stage-ui/src/components/FirstTimeSetup/FirstTimeSetupDialog.vue
Outdated
Show resolved
Hide resolved
…nced validation - Replace hardcoded strings with proper firstTimeSetup.* i18n keys - Implement useDebounceFn from @vueuse/core for robust debounced validation - Fix validation success/failed message keys - Improve code quality based on Copilot suggestions Related to moeru-ai#254
packages/stage-ui/src/components/FirstTimeSetup/FirstTimeSetupDialog.vue
Outdated
Show resolved
Hide resolved
…Dialog.vue Co-authored-by: Neko <neko@ayaka.moe>
…Dialog.vue Co-authored-by: Neko <neko@ayaka.moe>
…Dialog.vue Co-authored-by: Neko <neko@ayaka.moe>
…Dialog.vue Co-authored-by: Neko <neko@ayaka.moe>
…Dialog.vue Co-authored-by: Neko <neko@ayaka.moe>
…Dialog.vue Co-authored-by: Neko <neko@ayaka.moe>
Co-authored-by: Neko <neko@ayaka.moe>
Co-authored-by: Neko <neko@ayaka.moe>
Rename to onboarding-setup.ts
Change to 'i-svg-spinners:3-dots-fade'.
I will rename it to OnboardingDialog.vue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update this to packages/stage-ui/src/components/Onboarding/index.ts
once merged.
Close #254
Description
Linked Issues
Fixes #254
Additional context