Add support for f16 and f128 for toolchain upgrade to 6/28 #3306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhassan-aws
reviewed
Jun 28, 2024
tautschnig
reviewed
Jun 28, 2024
tautschnig
reviewed
Jun 28, 2024
zhassan-aws
approved these changes
Jun 28, 2024
celinval
reviewed
Jun 28, 2024
I was going to mention this in my overall comment, but completely forgot 🙈 |
celinval
previously requested changes
Jun 28, 2024
There was a problem hiding this comment.
Can you at least extend this test to include the new floating points?
https://github.com/model-checking/kani/blob/main/tests/kani/FloatingPoint/main.rs
This was referenced Jun 28, 2024
tautschnig
approved these changes
Jul 1, 2024
Review is stale as tests have been added.
adpaco-aws
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for f16 and f128, i.e
irep.Resolves #3303
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.