Allow excluding packages from verification with --exclude
#2399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhassan-aws
reviewed
Apr 20, 2023
There was a problem hiding this comment.
Thanks @adpaco-aws!
because it doesn't require --workspace (but it's implied anyway)
I'd prefer if we make --workspace required to keep the same interface as cargo build/test.
Thanks, it's required now. |
zhassan-aws
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR adds a
--excludeoption to Kani and allows excluding packages from verification (requested in #2375). It also adds validation for the packages passed to--packageand--excludeso we print a user-friendly error with all unknown packages, instead of usingexpectas we were doing for arguments to--package.Resolved issues:
Resolves #2375
Testing:
How is this change tested? Existing tests + 4 new ones.
Is this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.