Make cargo build-dev produce a proper exit code #2398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adpaco-aws
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
Thanks, @tautschnig ! Just a couple of minor comments.
If I'm not mistaken, this will prevent this error that @karkhaz had a while ago:
error: extern location for std does not exist: /home/runner/work/kani/kani/target/kani/lib/libstd.rlib
Indeed, I had very similar issues, and by now I've had them more than once... |
zhassan-aws
reviewed
Apr 20, 2023
Build failures of Kani-related components did not result in a non-zero exit code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Build failures of Kani-related components did not result in a non-zero exit code.
Resolved issues:
n/a
Related RFC:
n/a
Call-outs:
n/a
Testing:
How is this change tested? Tested locally, see https://github.com/model-checking/kani/actions/runs/4753845746/jobs/8445926203 for an example that I had not previously noticed in my local builds.
Is this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.