Skip to content

Conversation

tautschnig
Copy link
Member

Description of changes:

We should not spuriously attempt to push to a branch when branch protection prohibits this. To accomplish this, make the create-pull-request step conditional on no branch of the expected name existing before.

Resolved issues:

n/a

Related RFC:

n/a

Call-outs:

n/a

Testing:

  • How is this change tested? Tested in my fork.

  • Is this a refactor change? No.

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • n/a Methods or procedures are documented
  • n/a Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

We should not spuriously attempt to push to a branch when branch
protection prohibits this. To accomplish this, make the
create-pull-request step conditional on no branch of the expected name
existing before.
@tautschnig tautschnig requested a review from a team as a code owner April 14, 2023 15:15
Copy link
Contributor

@karkhaz karkhaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@tautschnig tautschnig enabled auto-merge (squash) April 14, 2023 15:30
@tautschnig tautschnig merged commit 55d1557 into model-checking:main Apr 14, 2023
@tautschnig tautschnig deleted the auto-pr-no-noise branch April 14, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants