Skip to content

Conversation

tautschnig
Copy link
Member

Fixes compiling the standard library, and avoids pinning to a particular minor version.

Resolves: #4303

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

Fixes compiling the standard library, and avoids pinning to a particular
minor version.

Resolves: model-checking#4303
@tautschnig tautschnig requested a review from a team as a code owner August 18, 2025 18:34
@github-actions github-actions bot added Z-EndToEndBenchCI Tag a PR to run benchmark CI Z-CompilerBenchCI Tag a PR to run benchmark CI labels Aug 18, 2025
Copy link
Contributor

@zhassan-aws zhassan-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which version of syn do we want to upgrade to? AFAIK, the change in this PR wouldn't affect the version used since "2.0.72" essentially means >= 2.0.72 (see Version requirement syntax). For example, this mornings automatic cargo update upgraded the syn version: https://github.com/model-checking/kani/pull/4302/files#diff-13ee4b2252c9e516a0547f2891aa2105c3ca71c6d7a1e682c69be97998dfc87eL2063.

@tautschnig
Copy link
Member Author

Which version of syn do we want to upgrade to? AFAIK, the change in this PR wouldn't affect the version used since "2.0.72" essentially means >= 2.0.72 (see Version requirement syntax). For example, this mornings automatic cargo update upgraded the syn version: https://github.com/model-checking/kani/pull/4302/files#diff-13ee4b2252c9e516a0547f2891aa2105c3ca71c6d7a1e682c69be97998dfc87eL2063.

Thank you, I had indeed misunderstood the version syntax. Closing as #4303 has indeed been fixed by #4302.

@tautschnig tautschnig closed this Aug 18, 2025
@tautschnig tautschnig deleted the use-latest-syn branch August 18, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-CompilerBenchCI Tag a PR to run benchmark CI Z-EndToEndBenchCI Tag a PR to run benchmark CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kani fails to compile libcore at nightly-2025-08-07
2 participants